[diffoscope] [PATCH] Graphical image comparison using libcaca (v2)

Reiner Herrmann reiner at reiner-h.de
Thu Dec 3 17:53:32 CET 2015


On Thu, Dec 03, 2015 at 05:52:27PM +0200, Chris Lamb wrote:
> Attached is an updated patch with tests as requested.

> +TEST_FILE1_PATH = os.path.join(os.path.dirname(__file__), '../data/test1.jpg')
> +TEST_FILE2_PATH = os.path.join(os.path.dirname(__file__), '../data/test2.jpg')

You forgot to include the images in the patch. :-)

> @@ -149,7 +150,8 @@ FILE_CLASSES = (
>      SquashfsFile,
>      TarFile,
>      XzFile,
> -    ZipFile
> +    ZipFile,
> +    ImageFile,
>      )

If you send v3, please keep this list sorted.


Regards,
 Reiner
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 801 bytes
Desc: Digital signature
URL: <http://lists.reproducible-builds.org/pipermail/diffoscope/attachments/20151203/6f638db8/attachment.sig>


More information about the diffoscope mailing list