[diffoscope] [PATCH] Graphical image comparison using libcaca (v2)
Jérémy Bobbio
lunar at debian.org
Thu Dec 3 18:05:05 CET 2015
Reiner Herrmann:
> On Thu, Dec 03, 2015 at 05:52:27PM +0200, Chris Lamb wrote:
> > Attached is an updated patch with tests as requested.
>
> > +TEST_FILE1_PATH = os.path.join(os.path.dirname(__file__), '../data/test1.jpg')
> > +TEST_FILE2_PATH = os.path.join(os.path.dirname(__file__), '../data/test2.jpg')
>
> You forgot to include the images in the patch. :-)
I took care of it and also added a reference diff. :)
> > @@ -149,7 +150,8 @@ FILE_CLASSES = (
> > SquashfsFile,
> > TarFile,
> > XzFile,
> > - ZipFile
> > + ZipFile,
> > + ImageFile,
> > )
>
> If you send v3, please keep this list sorted.
Please note that it's not strictly sorted by alphabetical order as more
precise tests need to be done before other ones.
--
Lunar .''`.
lunar at debian.org : :Ⓐ : # apt-get install anarchism
`. `'`
`-
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.reproducible-builds.org/pipermail/diffoscope/attachments/20151203/ab970cb5/attachment.sig>
More information about the diffoscope
mailing list