[Git][reproducible-builds/diffoscope][master] Silence/correct a SyntaxWarning message due to incorrectly comparing an...

Chris Lamb gitlab at salsa.debian.org
Tue Nov 26 14:49:56 UTC 2019



Chris Lamb pushed to branch master at Reproducible Builds / diffoscope


Commits:
ecef7e69 by Chris Lamb at 2019-11-26T14:47:21Z
Silence/correct a SyntaxWarning message due to incorrectly comparing an integer by identity vs. equality. Thanks, Boyuan Yang. (Closes: Debian:#945531, reproducible-builds/diffoscope#79)

- - - - -


1 changed file:

- diffoscope/comparators/zip.py


Changes:

=====================================
diffoscope/comparators/zip.py
=====================================
@@ -85,7 +85,7 @@ class Zipnote(Command):
         returncode = super().returncode
 
         # zipnote returns with an exit code of 3 for invalid archives
-        return 0 if returncode is 3 else returncode
+        return 0 if returncode == 3 else returncode
 
     def filter(self, line):
         """



View it on GitLab: https://salsa.debian.org/reproducible-builds/diffoscope/commit/ecef7e69f478b7e48f40193200359d704bdceaa1

-- 
View it on GitLab: https://salsa.debian.org/reproducible-builds/diffoscope/commit/ecef7e69f478b7e48f40193200359d704bdceaa1
You're receiving this email because of your account on salsa.debian.org.


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.reproducible-builds.org/pipermail/rb-commits/attachments/20191126/e00b59a8/attachment.htm>


More information about the rb-commits mailing list