[diffoscope] Tests on FreeBSD

[Mattia Rizzolo]

Hey! :)

On Mon, Jun 12, 2023 at 04:33:47PM -0400, Ed Maste wrote:
> I'd like to get FreeBSD into diffoscope CI, either by using
> Cirrus-CI's hosted service, or via GitLab CI.

That's a great idea! ^^
I'd probably stick with gitlab-ci (but I think it would need somebody to
provide a runner?) if anything just so that we can have everything
together…

> But to start off I had a
> look at the state of tests on FreeBSD and I see a few failures to sort
> out. There are also a number of skipped tests; I'm leaving those aside
> for now.
> 
> Summary (run on my laptop):

It's probably better if you open a bunch of (different!) bug reports on
salsa for the several test failures (with, maybe, a catchall one to
gather them as subtasks).

> A couple of the failures come from llvm_version() invoking
> llvm-config; in FreeBSD we have Clang and other primary LLVM tools in
> the base system but do not include llvm-config. Perhaps we can check
> the version of the specific tool we're using (i.e., llvm-dis /
> llvm-readobj / llvm-objdump)?

llvm-config is used only in _1_ test, so I'm sure it's possible to
change that, sure.

> tests/comparators/test_device.py::test_diff and ::test_diff_reverse,
> and tests/comparators/test_git.py::test_diff all fail because device
> ID (major/minor) do not match. I'm not sure how best to handle this,
> but I think we ought to have diffoscope elide them rather than having
> the test be permissive.

well, doesn't that change because of the different kernel?  If my
assumption is correct, then I think we should rather have diffoscope
recognize the running kernel type (linux vs bsd) and handle that
accordingly.
But still, bug please :)

-- 
regards,
                        Mattia Rizzolo

GPG Key: 66AE 2B4A FCCF 3F52 DA18  4D18 4B04 3FCD B944 4540      .''`.
More about me:  https://mapreri.org                             : :'  :
Launchpad user: https://launchpad.net/~mapreri                  `. `'`
Debian QA page: https://qa.debian.org/developer.php?login=mattia  `-
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://lists.reproducible-builds.org/pipermail/diffoscope/attachments/20230612/e429755e/attachment.sig>