[diffoscope] Tests on FreeBSD

Ed Maste emaste at freebsd.org
Mon Jun 12 20:45:37 UTC 2023


On Mon, 12 Jun 2023 at 16:33, Ed Maste <emaste at freebsd.org> wrote:
>
> It wasn't immediately clear to me what the issue is with the other
> tests (tests/comparators/test_pdf.py, tests/comparators/test_rlib.py,
> tests/comparators/test_squashfs.py, tests/comparators/test_zip.py).

test_zip.py::test_commented looks like it's because both zipinfo and
zipnote are needed. On my laptop I have zipnote installed but not
zipinfo.

Perhaps this:

diff --git a/tests/comparators/test_zip.py b/tests/comparators/test_zip.py
index 2c1446e6..19239411 100644
--- a/tests/comparators/test_zip.py
+++ b/tests/comparators/test_zip.py
@@ -140,6 +140,7 @@ def comment_differences(test_comment1, test_comment2):
     return test_comment1.compare(test_comment2).details


+ at skip_unless_tools_exist("zipinfo")
 @skip_unless_tools_exist("zipnote")
 def test_commented(comment_differences):
     assert_diff(comment_differences[1], "comment_zipinfo_expected_diff")


More information about the diffoscope mailing list