[diffoscope] 06/06: html-dir: Show start of diff on parent page, even when split over child pages
Ximin Luo
infinity0 at debian.org
Thu Sep 8 16:47:00 CEST 2016
Jérémy Bobbio:
> Ximin Luo:
>> In order to do this, we have to also ditch the previous behaviour where
>> max-diff-block-lines would interfere with diff's output on a deeper level,
>> hiding it from *all* readers. If this is really needed, we can add it back in
>> under a different name, that makes it obvious it operates at this deeper level
>> instead of merely affecting the diff visual output.
>
> I feel that this might result in very high memory usage in bad cases.
> I would recommend testing this on large input and low-end hardware
> beforing getting it into master.
>
I managed to redo the behaviour so this change was not necessary. However, I thought it was still not great to mix up display vs truncation, so I have moved this functionality into its own flag, --max-diff-block-lines-saved. This defaults to unlimited - I haven't run into problems with it myself, but people running this on low-end hardware could set it to something finite.
X
--
GPG: ed25519/56034877E1F87C35
GPG: rsa4096/1318EFAC5FBBDBCE
https://github.com/infinity0/pubkeys.git
More information about the diffoscope
mailing list