Need Help with duperemove in Debian

[Chris Lamb]

Hello Marc,

>> The real causes, however, are that GNU Make has some interesting and
>> nonintuitive sorting tripwires and you were caught out with them due
>> to an issue due to some particular filenames chosen by the upstream
>> duperemove developers.
>
> ... and them not using autotools, right? Or would that also happen with 
> plain autotools?

Maybe? :)  I've never really learned Autotools properly, but as I
understand it, they don't officially recommend you use wildcards at
all [0] so the value of myoutput_SOURCES is often hardcoded in simple
projects which are based on copy-pasting from the Autotools tutorial. :)

But in practice, this advice isn't really followed; see these hundreds
of packages in Debian [1]. But it only starts to matter with underscores
and capital letters etc. like duperremove as mentioned.

 [0] https://www.gnu.org/software/automake/manual/html_node/Wildcards.html
 [1] https://codesearch.debian.net/search?q=path%3AMakefile.am+wildcard

>>  -CFILES = $(filter-out tests.c,$(wildcard *.c))
>>  +CFILES = $(filter-out tests.c,$(sort $(wildcard *.c)))
[…]
>> No other changes are required. (This is better than changing the
>> debian/rules file as mentioned above, as it can be sent upstream.)
>
> Is that what you are suggesting? Or would there be a more "elegant" fix 
> that upstream could take?

Yes, I'm suggesting you propose this patch upstream. :)


Best wishes,

-- 
      o
    ⬋   ⬊      Chris Lamb
   o     o     reproducible-builds.org 💠
    ⬊   ⬋
      o