tests.reproducible-builds.org: build logs sent as gzip but no content-encoding, but only sometimes?

[Holger Levsen]

hi,

On Wed, Nov 15, 2023 at 10:42:25PM +0100, наб wrote:
> -- >8 --
> Subject: [PATCH] jenkins.d.n: AddEncoding gzip .gz, such that the files aren't
>  re-compressed as gzip, which some clients can't deal with, and it's a waste
>  of time
> 
> The current approach, under bookworm apache 2.4.57-2, returns:
>   (no accept-encoding)    -> content-encoding: gzip       + raw gzipped file
>   (accept-encoding: gzip) -> content-encoding: gzip, gzip + gzip(raw gzipped file)
> 
> This is valid, but on systems with ESET, or under lynx, opening
>   https://tests.reproducible-builds.org/debian/rbuild/unstable/amd64/systemd-cron_2.3.0-1.rbuild.log.gz
> would just return a garbled result: they match content-encoding
> directly, instead of tokenising it.
> 
> The scary comment doesn't seem to apply to apache 2.4.57-2.
> ---
>  .../etc/apache2/sites-available/jenkins.debian.net.conf       | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/hosts/jenkins/etc/apache2/sites-available/jenkins.debian.net.conf b/hosts/jenkins/etc/apache2/sites-available/jenkins.debian.net.conf
> index 289c6240c..5e40b9aaa 100644
> --- a/hosts/jenkins/etc/apache2/sites-available/jenkins.debian.net.conf
> +++ b/hosts/jenkins/etc/apache2/sites-available/jenkins.debian.net.conf
> @@ -87,9 +87,7 @@
>  	</Directory>
>  
>  	<FilesMatch "\.gz$">
> -		Header append Content-Encoding gzip
> -		# this causes errors 406 to clients connecting without Accept-Encoding=gzip.
> -		#AddEncoding gzip .gz
> +		AddEncoding gzip .gz
>  		ForceType text/plain
>  	</FilesMatch>

I've deployed this patch now and am cc:ing Mattia, so he can doublecheck it's
fine.

Next time please do send a proper git patch, it was a tiny bit cumbersome to
extract it from the email and add a From: header. No big deal neither, but.

& thank you!


-- 
cheers,
	Holger

 ⢀⣴⠾⠻⢶⣦⠀
 ⣾⠁⢠⠒⠀⣿⡁  holger@(debian|reproducible-builds|layer-acht).org
 ⢿⡄⠘⠷⠚⠋⠀  OpenPGP: B8BF54137B09D35CF026FE9D 091AB856069AAA1C
 ⠈⠳⣄

Make earth cool again.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://lists.reproducible-builds.org/pipermail/rb-general/attachments/20231117/9d48f094/attachment.sig>