[rb-general] Refactoring adt_testbed on reprotest
Ximin Luo
infinity0 at debian.org
Thu Aug 17 20:10:00 CEST 2017
Santiago Torres:
> Hey, X.
>
>> You don't need to wait, you can pull the reprotest tree, the code is duplicated there.
>>
>> If I try to "git-merge" your branch there are just a few conflicts that don't seem too hard to resolve. Also if you exclude the earliest two commits for now, it should avoid some of these conflicts.
>>
>
> I did a refactoring with the changes you suggested. I made a separate
> branch just so that the rebased history doesn't remove the "precedent".
> You can find the new branch on [1].
>
> Should I go on and do a PR on GitHub, or should I send-mail to a ML?
>
Hey, sorry for the delay. I made a few tweaks and have pushed the changes to git master. I used `git rebase --interactive` with some squashing, normally I would've committed on top but wanted to keep the number of commits low to make it easier to re-apply to autopkgtest in the future.
I hope it works well for you! At the moment I have no easy way to test it against Arch Linux, but the refactoring seems to not have broken anything on Debian. Let me know if you need to make further commits.
X
--
GPG: ed25519/56034877E1F87C35
GPG: rsa4096/1318EFAC5FBBDBCE
https://github.com/infinity0/pubkeys.git
More information about the rb-general
mailing list