[Git][reproducible-builds/diffoscope][master] Misc. cosmetic changes to previous commit.

[Chris Lamb (@lamby)]

Chris Lamb pushed to branch master at Reproducible Builds / diffoscope


Commits:
cf99aab7 by Chris Lamb at 2025-03-29T17:17:31+00:00
Misc. cosmetic changes to previous commit.

- - - - -


1 changed file:

- diffoscope/comparators/directory.py


Changes:

=====================================
diffoscope/comparators/directory.py
=====================================
@@ -17,11 +17,11 @@
 # You should have received a copy of the GNU General Public License
 # along with diffoscope.  If not, see <https://www.gnu.org/licenses/>.
 
+import logging
 import os
 import re
-import logging
+import stat
 import subprocess
-from stat import S_ISDIR
 
 from diffoscope.exc import RequiredToolNotFound
 from diffoscope.tools import python_module_missing, tool_required
@@ -85,10 +85,10 @@ def stat_result_to_tuple(stat):
         stat.st_mode,
         stat.st_uid,
         stat.st_gid,
-        # Directory sizes are arbitrary, file system dependent, and may differ,
-        # depending on the history of the directory.
-        # E.g. see https://github.com/NixOS/nixpkgs/issues/393375
-        stat.st_size if not S_ISDIR(stat.st_mode) else None,
+        # Directory sizes are essentially arbitrary and filesystem dependent,
+        # and may even differ, depending on the history of the directory.
+        # (See MR !150)
+        stat.st_size if not stat.S_ISDIR(stat.st_mode) else None,
         stat.st_mtime,
     )
 



View it on GitLab: https://salsa.debian.org/reproducible-builds/diffoscope/-/commit/cf99aab7d493b36c21fc02ad93fff2ee9ad6b434

-- 
View it on GitLab: https://salsa.debian.org/reproducible-builds/diffoscope/-/commit/cf99aab7d493b36c21fc02ad93fff2ee9ad6b434
You're receiving this email because of your account on salsa.debian.org.


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.reproducible-builds.org/pipermail/rb-commits/attachments/20250329/27d1a774/attachment.htm>