[Git][reproducible-builds/diffoscope][master] Use --walk over (potentially dangerous) --scan argument of zipdetails(1)....

[Chris Lamb (@lamby)]

Chris Lamb pushed to branch master at Reproducible Builds / diffoscope


Commits:
661adfc0 by Chris Lamb at 2025-04-29T13:31:37-07:00
Use --walk over (potentially dangerous) --scan argument of zipdetails(1). (Closes: reproducible-builds/diffoscope#406)

- - - - -


1 changed file:

- diffoscope/comparators/zip.py


Changes:

=====================================
diffoscope/comparators/zip.py
=====================================
@@ -157,7 +157,9 @@ def zipinfo_differences(file, other):
 class Zipdetails(Command):
     @tool_required("zipdetails")
     def cmdline(self):
-        return ["zipdetails", "--redact", "--scan", "--utc", self.path]
+        # See <https://salsa.debian.org/reproducible-builds/diffoscope/-/issues/406>
+        # for discussion of zipdetails command line arguments.
+        return ["zipdetails", "--redact", "--walk", "--utc", self.path]
 
 
 class ZipDirectory(Directory, ArchiveMember):



View it on GitLab: https://salsa.debian.org/reproducible-builds/diffoscope/-/commit/661adfc05b88e5275db8509d72236834029538ef

-- 
View it on GitLab: https://salsa.debian.org/reproducible-builds/diffoscope/-/commit/661adfc05b88e5275db8509d72236834029538ef
You're receiving this email because of your account on salsa.debian.org.


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.reproducible-builds.org/pipermail/rb-commits/attachments/20250429/2e08618a/attachment.htm>