[Git][reproducible-builds/diffoscope][master] Don't try and compare rdb_expected_diff on non-GNU systems as %p formatting can vary. (Re: #364)

[Chris Lamb (@lamby)]

Chris Lamb pushed to branch master at Reproducible Builds / diffoscope


Commits:
c09d0a9e by Chris Lamb at 2024-02-27T15:01:18+00:00
Don't try and compare rdb_expected_diff on non-GNU systems as %p formatting can vary. (Re: #364)

For instance, `printf("%p\n", NULL);` prints "(nil)" with GLIBC and "0x0"
on MacOS.

- - - - -


1 changed file:

- tests/comparators/test_rdata.py


Changes:

=====================================
tests/comparators/test_rdata.py
=====================================
@@ -21,6 +21,7 @@ import re
 import pytest
 import subprocess
 
+from diffoscope.tools import os_is_gnu
 from diffoscope.comparators.gzip import GzipFile
 from diffoscope.comparators.rdata import RdbFile
 
@@ -71,6 +72,9 @@ def test_num_items_rdb(differences_rdb):
     assert len(differences_rdb) == 1
 
 
+ at pytest.mark.skipif(
+    not os_is_gnu(), reason="requires GNU stdlib for consistent %p formatting"
+)
 @skip_unless_tools_exist("Rscript")
 @skip_unless_tool_is_at_least("Rscript", rscript_version, "4.2.0")
 def test_item_rdb(differences_rdb):



View it on GitLab: https://salsa.debian.org/reproducible-builds/diffoscope/-/commit/c09d0a9e6ceb2e948bcade3f417a916211cdf52a

-- 
View it on GitLab: https://salsa.debian.org/reproducible-builds/diffoscope/-/commit/c09d0a9e6ceb2e948bcade3f417a916211cdf52a
You're receiving this email because of your account on salsa.debian.org.


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.reproducible-builds.org/pipermail/rb-commits/attachments/20240227/d2150453/attachment.htm>