[Git][reproducible-builds/diffoscope][master] Be more specific about the minimum required version of readelf (ie. binutils),...

[Chris Lamb (@lamby)]

Chris Lamb pushed to branch master at Reproducible Builds / diffoscope


Commits:
280ff401 by Chris Lamb at 2022-06-22T12:29:29+01:00
Be more specific about the minimum required version of readelf (ie. binutils), as it appears that this "patch" level version change resulted in a change of output, not the "minor" version.

binutils 2.38-4 in Debian uses "retq" but 2.38.50.20220615-4 uses "ret".

- - - - -


1 changed file:

- tests/comparators/test_elf.py


Changes:

=====================================
tests/comparators/test_elf.py
=====================================
@@ -95,7 +95,7 @@ def test_obj_compare_non_existing(monkeypatch, obj1):
 
 
 @skip_unless_tools_exist("readelf")
- at skip_unless_tool_is_at_least("readelf", readelf_version, "2.38")
+ at skip_unless_tool_is_at_least("readelf", readelf_version, "2.38.50")
 @skip_if_binutils_does_not_support_x86()
 def test_diff(obj_differences):
     assert len(obj_differences) == 1
@@ -131,7 +131,7 @@ def lib_differences(lib1, lib2):
 
 
 @skip_unless_tools_exist("readelf", "objdump")
- at skip_unless_tool_is_at_least("readelf", readelf_version, "2.38")
+ at skip_unless_tool_is_at_least("readelf", readelf_version, "2.38.50")
 @skip_if_binutils_does_not_support_x86()
 def test_lib_differences(lib_differences):
     assert len(lib_differences) == 2
@@ -173,7 +173,7 @@ def libmix_differences(libmix1, libmix2):
 @skip_unless_tools_exist("xxd")
 @skip_unless_tools_exist("llvm-readobj", "llvm-objdump")
 @skip_unless_tools_exist("readelf", "objdump")
- at skip_unless_tool_is_at_least("readelf", readelf_version, "2.38")
+ at skip_unless_tool_is_at_least("readelf", readelf_version, "2.38.50")
 @skip_if_binutils_does_not_support_x86()
 def test_libmix_differences(libmix_differences):
     assert len(libmix_differences) == 5



View it on GitLab: https://salsa.debian.org/reproducible-builds/diffoscope/-/commit/280ff40115af104685932b96e83ccb79f78afabb

-- 
View it on GitLab: https://salsa.debian.org/reproducible-builds/diffoscope/-/commit/280ff40115af104685932b96e83ccb79f78afabb
You're receiving this email because of your account on salsa.debian.org.


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.reproducible-builds.org/pipermail/rb-commits/attachments/20220622/eb535c5c/attachment.htm>