[Git][reproducible-builds/diffoscope][master] 2 commits: Revert "Skip Python bytecode testing where we do not have an expected diff....

Vagrant Cascadian (@vagrant) gitlab at salsa.debian.org
Sun Oct 31 01:54:30 UTC 2021



Vagrant Cascadian pushed to branch master at Reproducible Builds / diffoscope


Commits:
d90e6233 by Vagrant Cascadian at 2021-10-30T17:53:05-07:00
Revert "Skip Python bytecode testing where we do not have an expected diff. (Closes: reproducible-builds/diffoscope#284)"

This reverts commit ef878ecad7d4278d675434ca5d59dd430ea9052c.

- - - - -
4f7d531d by Vagrant Cascadian at 2021-10-30T17:56:19-07:00
Skip Python bytecode testing when "file" is older than 5.39.

(Closes: reproducible-builds/diffoscope#284)

- - - - -


1 changed file:

- tests/comparators/test_python.py


Changes:

=====================================
tests/comparators/test_python.py
=====================================
@@ -22,13 +22,16 @@ import sys
 from diffoscope.comparators.python import PycFile
 
 from ..utils.data import assert_diff_startswith, load_fixture
-from ..utils.tools import skipif
-
+from ..utils.tools import (
+    skipif,
+    skip_unless_file_version_is_at_least,
+)
 
 pyc1 = load_fixture("test1.pyc-renamed")
 pyc2 = load_fixture("test2.pyc-renamed")
 
 
+ at skip_unless_file_version_is_at_least("5.39")
 def test_identification(pyc1, pyc2):
     assert isinstance(pyc1, PycFile)
     assert isinstance(pyc2, PycFile)
@@ -47,10 +50,7 @@ def differences(pyc1, pyc2):
     return pyc1.compare(pyc2).details
 
 
- at skipif(
-    sys.version_info < (3, 9),
-    reason="pyc_expected_diff generated on Python 3.9",
-)
+ at skip_unless_file_version_is_at_least("5.39")
 def test_diff(differences):
     assert_diff_startswith(
         differences[0],



View it on GitLab: https://salsa.debian.org/reproducible-builds/diffoscope/-/compare/a154bb713dbcbd1222f6fc9b1ac7dd05c061e10e...4f7d531dd8ac5afb6e5d00eab17c0cfa3dc897d3

-- 
View it on GitLab: https://salsa.debian.org/reproducible-builds/diffoscope/-/compare/a154bb713dbcbd1222f6fc9b1ac7dd05c061e10e...4f7d531dd8ac5afb6e5d00eab17c0cfa3dc897d3
You're receiving this email because of your account on salsa.debian.org.


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.reproducible-builds.org/pipermail/rb-commits/attachments/20211031/02e59d4c/attachment.htm>


More information about the rb-commits mailing list