[Git][reproducible-builds/diffoscope][master] 2 commits: Clarify the comment about the HUGE_TOOLS dict.

[Chris Lamb (@lamby)]

Chris Lamb pushed to branch master at Reproducible Builds / diffoscope


Commits:
0649fb3e by Chris Lamb at 2021-08-31T15:15:56+01:00
Clarify the comment about the HUGE_TOOLS dict.

- - - - -
a0486e57 by Chris Lamb at 2021-08-31T15:15:56+01:00
Format the debug messages for elf sections using diffoscope.utils.format_class.

- - - - -


2 changed files:

- diffoscope/comparators/elf.py
- diffoscope/external_tools.py


Changes:

=====================================
diffoscope/comparators/elf.py
=====================================
@@ -491,7 +491,12 @@ class ElfContainer(DecompilableContainer):
                 ][0]
 
                 logger.debug(
-                    "Adding section %s (%s) as %s", name, type, elf_class
+                    "Adding section %s (%s) as %s",
+                    name,
+                    type,
+                    format_class(
+                        elf_class, strip="diffoscope.comparators.elf."
+                    ),
                 )
                 self._sections[name] = elf_class(self, name)
 


=====================================
diffoscope/external_tools.py
=====================================
@@ -250,10 +250,10 @@ REMAPPED_TOOL_NAMES = {}
 # version (so that our tests don't break) then it's unnecessary to add it here.
 GNU_TOOL_NAMES = {"diff", "readelf", "objcopy", "objdump"}
 
-# Set of tools considered "large" their installation size, or too niche in
-# their target users.  To be easily excluded from installation if not
-# specifically required.
-# These are the names of the tools, not package names.
+# Set of tools considered "large" in their installation size or too niche in
+# their target users. This is so they can easily be excluded from installation
+# if not required in most cases. Note that these are the names of the tools
+# (ie. the keys in the EXTERNAL_TOOLS dict), not the package names.
 HUGE_TOOLS = {
     "ghc",
     "ocamlobjinfo",



View it on GitLab: https://salsa.debian.org/reproducible-builds/diffoscope/-/compare/0c680ec8fefd6478deb7504c3df75d083ffe70f8...a0486e571a5fe447e853c7be35819381f43c163c

-- 
View it on GitLab: https://salsa.debian.org/reproducible-builds/diffoscope/-/compare/0c680ec8fefd6478deb7504c3df75d083ffe70f8...a0486e571a5fe447e853c7be35819381f43c163c
You're receiving this email because of your account on salsa.debian.org.


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.reproducible-builds.org/pipermail/rb-commits/attachments/20210831/f07fd41d/attachment.htm>