[Git][reproducible-builds/diffoscope][master] Mention in the diff if apksigner is missing.

Chris Lamb (@lamby) gitlab at salsa.debian.org
Wed Aug 25 09:51:23 UTC 2021



Chris Lamb pushed to branch master at Reproducible Builds / diffoscope


Commits:
07c016a3 by Chris Lamb at 2021-08-25T10:50:50+01:00
Mention in the diff if apksigner is missing.

- - - - -


1 changed file:

- diffoscope/comparators/apk.py


Changes:

=====================================
diffoscope/comparators/apk.py
=====================================
@@ -223,9 +223,9 @@ class ApkFile(ZipFileBase):
             x = Difference.from_operation(Apksigner, self.path, other.path)
             if x is not None:
                 differences.insert(0, x)
-        except RequiredToolNotFound:  # noqa
+        except RequiredToolNotFound as exc:  # noqa
             # Don't require apksigner
-            pass
+            self.add_comment(exc.get_comment())
 
         return differences
 



View it on GitLab: https://salsa.debian.org/reproducible-builds/diffoscope/-/commit/07c016a365630f1ae398fca6de16a7869d2c4534

-- 
View it on GitLab: https://salsa.debian.org/reproducible-builds/diffoscope/-/commit/07c016a365630f1ae398fca6de16a7869d2c4534
You're receiving this email because of your account on salsa.debian.org.


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.reproducible-builds.org/pipermail/rb-commits/attachments/20210825/253dec5e/attachment.htm>


More information about the rb-commits mailing list