[Git][reproducible-builds/diffoscope][master] Don't alias output from os.path.splitext to variables that we do not end up using.

[Chris Lamb]

Chris Lamb pushed to branch master at Reproducible Builds / diffoscope


Commits:
2bd5eca2 by Chris Lamb at 2020-09-01T10:41:07+01:00
Don't alias output from os.path.splitext to variables that we do not end up using.

- - - - -


2 changed files:

- diffoscope/comparators/deb.py
- diffoscope/comparators/utils/libarchive.py


Changes:

=====================================
diffoscope/comparators/deb.py
=====================================
@@ -100,7 +100,7 @@ class DebContainer(LibarchiveContainer):
         other_members = dict(other_members)
 
         for name1 in my_members.keys():
-            main, ext = os.path.splitext(name1)
+            main, _ = os.path.splitext(name1)
             candidates = [
                 name2
                 for name2 in other_members.keys() - matched


=====================================
diffoscope/comparators/utils/libarchive.py
=====================================
@@ -309,7 +309,7 @@ class LibarchiveContainer(Archive):
                 # Keep directory sizes small. could be improved but should be
                 # good enough for "ordinary" large archives.
                 dst = os.path.join(tmpdir, str(idx // 4096), str(idx % 4096))
-                root, ext = os.path.splitext(entry.pathname)
+                _, ext = os.path.splitext(entry.pathname)
                 dst += ext
                 # Maintain a mapping of archive path to the extracted path,
                 # avoiding the need to sanitise filenames.



View it on GitLab: https://salsa.debian.org/reproducible-builds/diffoscope/-/commit/2bd5eca2af59f14e290c87c36840baed31c5ad99

-- 
View it on GitLab: https://salsa.debian.org/reproducible-builds/diffoscope/-/commit/2bd5eca2af59f14e290c87c36840baed31c5ad99
You're receiving this email because of your account on salsa.debian.org.


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.reproducible-builds.org/pipermail/rb-commits/attachments/20200901/07e30b51/attachment.htm>