[Git][reproducible-builds/diffoscope][master] progress: don't crash when progressbar is missing but requested.

Mattia Rizzolo gitlab at salsa.debian.org
Sun Sep 1 09:45:03 UTC 2019



Mattia Rizzolo pushed to branch master at Reproducible Builds / diffoscope


Commits:
7294ff9e by Mattia Rizzolo at 2019-09-01T09:44:21Z
progress: don't crash when progressbar is missing but requested.

Closes: #939085
Signed-off-by: Mattia Rizzolo <mattia at debian.org>

- - - - -


1 changed file:

- diffoscope/progress.py


Changes:

=====================================
diffoscope/progress.py
=====================================
@@ -80,7 +80,11 @@ class ProgressManager(object):
             except ImportError:
                 # User asked for bar, so show them the error
                 if parsed_args.progress:
-                    raise
+                    logging.error(
+                        "Progress bar requested, but the 'progressbar' "
+                        "python module is missing."
+                    )
+                    logging.error("Continuing without progress bar.")
 
         if parsed_args.status_fd:
             self.register(StatusFD(os.fdopen(parsed_args.status_fd, 'w')))



View it on GitLab: https://salsa.debian.org/reproducible-builds/diffoscope/commit/7294ff9e1c4e0256711ebc7bfce182d51f1e74c2

-- 
View it on GitLab: https://salsa.debian.org/reproducible-builds/diffoscope/commit/7294ff9e1c4e0256711ebc7bfce182d51f1e74c2
You're receiving this email because of your account on salsa.debian.org.


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.reproducible-builds.org/pipermail/rb-commits/attachments/20190901/3fa44852/attachment.html>


More information about the rb-commits mailing list