[Git][reproducible-builds/diffoscope][master] 2 commits: comparators.ppu: Fix inverted logic and invalid reference to "file".

Chris Lamb gitlab at salsa.debian.org
Sun Jan 13 20:36:18 CET 2019


Chris Lamb pushed to branch master at Reproducible Builds / diffoscope


Commits:
248e9baa by Chris Lamb at 2019-01-13T19:19:32Z
comparators.ppu: Fix inverted logic and invalid reference to "file".

These were regressions introduced in f0ae5eba85.

- - - - -
a034dc2e by Chris Lamb at 2019-01-13T19:21:08Z
releasing package diffoscope version 108

- - - - -


3 changed files:

- debian/changelog
- diffoscope/__init__.py
- diffoscope/comparators/ppu.py


Changes:

=====================================
debian/changelog
=====================================
@@ -1,3 +1,37 @@
+diffoscope (108) unstable; urgency=medium
+
+  [ Chris Lamb ]
+  * test_icc: Calculate the path to a test .icc file using data() rather than
+    using the pytest fixture itself to avoid a "Fixtures are not meant to be
+    called directly" warning/error. (Closes: #916226)
+  * Fix a test_mozzip_compressed_files test failure under Alpine Linux.
+    (Closes: #916353, MR: !8)
+  * Output improvements:
+    * Prefer to comment that files are identical rather than having a
+      "fuzziness score" of zero.
+    * Expand the padding/spacing for "N calls" in the profiling output; having
+      99,999+ calls to cmp(1) is not uncommon for ISOs.
+    * Add a note to the "Files similar despite different names" comment to
+      clarify that a lower score is more similar.
+  * Use File.file_header to tidy JSON matching in the json, ppu and wasm
+    comparators.
+  * Drop debbindiff Breaks/Replaces; was removed in 2015, never part of a
+    stable release, etc.
+  * Correct a "positives" typo.
+
+  [ Joachim Breitner ]
+  * Add support for comparing WebAssembly modules. (MR: !17)
+
+  [ Holger Levsen ]
+  * Bump Standards-Version to 4.3.0
+  * Clarify that (upstream) issues should be reported via the
+    issue tracker on salsa.debian.org.
+
+  [ Mattia Rizzolo ]
+  * Try matching for MozillaZipFile before ZipFile.
+
+ -- Chris Lamb <lamby at debian.org>  Sun, 13 Jan 2019 19:21:05 +0000
+
 diffoscope (107) unstable; urgency=medium
 
   * Compare .zip file comments with zipnote. (Closes: #901757)


=====================================
diffoscope/__init__.py
=====================================
@@ -17,4 +17,4 @@
 # You should have received a copy of the GNU General Public License
 # along with diffoscope.  If not, see <https://www.gnu.org/licenses/>.
 
-VERSION = "107"
+VERSION = "108"


=====================================
diffoscope/comparators/ppu.py
=====================================
@@ -66,10 +66,10 @@ class PpuFile(File):
         if not super().recognizes(file):
             return False
 
-        if file.file_header.startswith(b'PPU'):
+        if not file.file_header.startswith(b'PPU'):
             return False
 
-        ppu_version = f.file_header[3:6].decode('ascii', errors='ignore')
+        ppu_version = file.file_header[3:6].decode('ascii', errors='ignore')
 
         if not hasattr(PpuFile, 'ppu_version'):
             try:



View it on GitLab: https://salsa.debian.org/reproducible-builds/diffoscope/compare/3a9cf0d0f043bd95d59b163c658a38e9ba10e947...a034dc2e92320bfb6933ad6db090fdb7a67bff18

-- 
View it on GitLab: https://salsa.debian.org/reproducible-builds/diffoscope/compare/3a9cf0d0f043bd95d59b163c658a38e9ba10e947...a034dc2e92320bfb6933ad6db090fdb7a67bff18
You're receiving this email because of your account on salsa.debian.org.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.reproducible-builds.org/pipermail/rb-commits/attachments/20190113/59b9f70f/attachment.html>


More information about the rb-commits mailing list