[Git][reproducible-builds/diffoscope][master] 2 commits: Prefer to comment that files are identical rather than having a "fuzziness score" of zero.

[Chris Lamb]

Chris Lamb pushed to branch master at Reproducible Builds / diffoscope


Commits:
9f30b4b2 by Chris Lamb at 2019-01-06T12:55:43Z
Prefer to comment that files are identical rather than having a "fuzziness score" of zero.

- - - - -
3a9cf0d0 by Chris Lamb at 2019-01-06T12:57:18Z
Add a note to the "Files similar despite different names" comment to clarify that a lower score is more similar.

- - - - -


1 changed file:

- diffoscope/comparators/utils/container.py


Changes:

=====================================
diffoscope/comparators/utils/container.py
=====================================
@@ -157,7 +157,9 @@ class Container(object, metaclass=abc.ABCMeta):
 
             for my_name, other_name, score in self.perform_fuzzy_matching(my_members, other_members):
                 comment = "Files similar despite different names" \
-                    " (difference score: {})".format(score)
+                    " (score: {}, lower is more similar)".format(score)
+                if score == 0:
+                    comment = "Files identical despite different names"
                 yield prep_yield(my_name, other_name, comment)
 
             if Config().new_file:



View it on GitLab: https://salsa.debian.org/reproducible-builds/diffoscope/compare/21e4c1ddadbfd79ba2c2d39eaa05671645e43500...3a9cf0d0f043bd95d59b163c658a38e9ba10e947

-- 
View it on GitLab: https://salsa.debian.org/reproducible-builds/diffoscope/compare/21e4c1ddadbfd79ba2c2d39eaa05671645e43500...3a9cf0d0f043bd95d59b163c658a38e9ba10e947
You're receiving this email because of your account on salsa.debian.org.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.reproducible-builds.org/pipermail/rb-commits/attachments/20190106/42838fe3/attachment.html>