[Git][reproducible-builds/diffoscope][master] Drop "DOS/MBR" source string test.

[Chris Lamb]

Chris Lamb pushed to branch master at Reproducible Builds / diffoscope


Commits:
40e5a5f1 by Chris Lamb at 2019-02-20T13:54:27Z
Drop "DOS/MBR" source string test.

This always seemed heavy-handed to me, both technically (there should be real
tests for any incorrect identification of file format, etc.) but moreover from
a community/collaborative point of view.

- - - - -


1 changed file:

- tests/test_source.py


Changes:

=====================================
tests/test_source.py
=====================================
@@ -18,7 +18,6 @@
 # along with diffoscope.  If not, see <https://www.gnu.org/licenses/>.
 
 import os
-import glob
 import diffoscope
 import subprocess
 
@@ -27,12 +26,6 @@ from .utils.tools import skip_unless_tools_exist
 BASE_DIR = os.path.dirname(os.path.abspath(diffoscope.__file__))
 
 
-def test_dos_mbr():
-    for x in glob.iglob(os.path.join(BASE_DIR, '**', '*.py'), recursive=True):
-        with open(x, 'rb') as f:
-            assert b'DOS/MBR' not in f.read()
-
-
 @skip_unless_tools_exist('black')
 def test_code_is_black_clean():
     output = subprocess.check_output(



View it on GitLab: https://salsa.debian.org/reproducible-builds/diffoscope/commit/40e5a5f115e7de8b455e11f30d1e6f9c83ec0c37

-- 
View it on GitLab: https://salsa.debian.org/reproducible-builds/diffoscope/commit/40e5a5f115e7de8b455e11f30d1e6f9c83ec0c37
You're receiving this email because of your account on salsa.debian.org.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.reproducible-builds.org/pipermail/rb-commits/attachments/20190224/a0269ca8/attachment.html>