[diffoscope] Test failures without "tlsh" module

[Fabian Keil]

Mattia Rizzolo <mattia at mapreri.org> wrote:

> On Wed, Jun 10, 2020 at 11:57:21AM +0200, Fabian Keil wrote:
> > I submitted a diffoscope update to 146 for FreeBSD and it was pointed
> > out by Kubilay Kocak that there are lots of errors during make test:
> > https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=246773#c2
> > 
> > I could reproduce this and as noted by Kubilay, most of
> > them are caused by the no-tlsh-module warning which the
> > tests don't seem to expect.
> 
> For these, could you please try the following diff?

Thanks a lot for the quick patch.

With it, the failed tests are down to 19:
https://www.fabiankeil.de/tmp/diffoscope-146.1-tests.txt

> > Note that there are also "list index out of range" errors
> > which may be unrelated:
> 
> These are more problematic, and might require some real debugging
> though…
> 
> > Is the missing "tlsh" module really important enough to
> > show the warning every time diffoscope is executed?
> 
> well, it might not be…
> It was changed more than a year ago, after somebody requested it…
> https://salsa.debian.org/reproducible-builds/diffoscope/commit/292895cad5c5304cb865f69e980e4edccca2cf0e
> 
> But I can tell you that in my experience the lack of fuzzy matching does
> degrate the experience quite a lot.

Okay.

Fabian
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <http://lists.reproducible-builds.org/pipermail/diffoscope/attachments/20200610/0656f30e/attachment.sig>