[diffoscope] 02/02: tests: binary: fix test after 934dfff

Mattia Rizzolo mattia at debian.org
Thu Mar 8 12:27:12 CET 2018


This is an automated email from the git hooks/post-receive script.

mattia pushed a commit to branch master
in repository diffoscope.

commit 014908f0a890498fd545f7d7812bfd8a234c58a6
Author: Mattia Rizzolo <mattia at debian.org>
Date:   Thu Mar 8 12:20:08 2018 +0100

    tests: binary: fix test after 934dfff
    
    Signed-off-by: Mattia Rizzolo <mattia at debian.org>
---
 tests/comparators/test_binary.py | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/tests/comparators/test_binary.py b/tests/comparators/test_binary.py
index 2ed5d27..66db18c 100644
--- a/tests/comparators/test_binary.py
+++ b/tests/comparators/test_binary.py
@@ -145,7 +145,10 @@ def test_with_compare_details_and_failed_process():
 
     class MockFile(FilesystemFile):
         def compare_details(self, other, source=None):
-            subprocess.check_output(['sh', '-c', 'echo "%s"; exit 42' % output], shell=False)
+            subprocess.check_output(
+                ['sh', '-c', 'echo "%s"; exit 42' % output],
+                encoding='utf-8',
+            )
             raise Exception('should not be run')
     difference = MockFile(TEST_FILE1_PATH).compare(MockFile(TEST_FILE2_PATH))
     expected_diff = get_data('../data/binary_expected_diff')

-- 
Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/reproducible/diffoscope.git


More information about the diffoscope mailing list