[diffoscope] 02/02: comparators.binwalk: Expand comment on why we need to manually detect RPM files in the binwalk comparator.

[Chris Lamb]

This is an automated email from the git hooks/post-receive script.

lamby pushed a commit to branch master
in repository diffoscope.

commit 0a508581777da4dbfeeb332474e600ee6adfc28d
Author: Chris Lamb <lamby at debian.org>
Date:   Sat Sep 9 21:14:48 2017 +0100

    comparators.binwalk: Expand comment on why we need to manually detect RPM files in the binwalk comparator.
---
 diffoscope/comparators/binwalk.py | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/diffoscope/comparators/binwalk.py b/diffoscope/comparators/binwalk.py
index b14cd0f..0382cf0 100644
--- a/diffoscope/comparators/binwalk.py
+++ b/diffoscope/comparators/binwalk.py
@@ -66,7 +66,9 @@ class BinwalkFile(File):
         if not super().recognizes(file):
             return False
 
-        # RPM files are .cpio, but let's always leave it to the RPM comparator
+        # RPM files are .cpio, but let's always leave it to the RPM comparator.
+        # This avoids the RpmFile > BinWalkFile > CpioFile > RpmFile circular
+        # ordering dependency.
         if file.container and isinstance(file.container.source, RpmFile):
             return False
 

-- 
Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/reproducible/diffoscope.git