[diffoscope] 01/01: Test that we do not recursively unpack archive quines. See <https://research.swtch.com/zip> for more information.

[Chris Lamb]

This is an automated email from the git hooks/post-receive script.

lamby pushed a commit to branch experimental
in repository diffoscope.

commit 1f5694c80e711ac64194dd84963f53ca2d3502ee
Author: Chris Lamb <lamby at debian.org>
Date:   Fri May 12 10:34:20 2017 +0200

    Test that we do not recursively unpack archive quines. See <https://research.swtch.com/zip> for more information.
    
    Signed-off-by: Chris Lamb <lamby at debian.org>
---
 tests/data/quine.gz            | Bin 0 -> 250 bytes
 tests/data/quine.zip           | Bin 0 -> 440 bytes
 tests/data/quine_expected_diff |   3 +++
 tests/test_quines.py           |  51 +++++++++++++++++++++++++++++++++++++++++
 4 files changed, 54 insertions(+)

diff --git a/tests/data/quine.gz b/tests/data/quine.gz
new file mode 100644
index 0000000..d6f7f87
Binary files /dev/null and b/tests/data/quine.gz differ
diff --git a/tests/data/quine.zip b/tests/data/quine.zip
new file mode 100644
index 0000000..ea0fa2f
Binary files /dev/null and b/tests/data/quine.zip differ
diff --git a/tests/data/quine_expected_diff b/tests/data/quine_expected_diff
new file mode 100644
index 0000000..d687ad0
--- /dev/null
+++ b/tests/data/quine_expected_diff
@@ -0,0 +1,3 @@
+@@ -1 +1 @@
+-gzip compressed data, was "recursive", from FAT filesystem (MS-DOS, OS/2, NT)
++Zip archive data, at least v2.0 to extract
diff --git a/tests/test_quines.py b/tests/test_quines.py
new file mode 100644
index 0000000..0f4d3ce
--- /dev/null
+++ b/tests/test_quines.py
@@ -0,0 +1,51 @@
+# -*- coding: utf-8 -*-
+#
+# diffoscope: in-depth comparison of files, archives, and directories
+#
+# Copyright © 2017 Chris Lamb <lamby at debian.org>
+#
+# diffoscope is free software: you can redistribute it and/or modify
+# it under the terms of the GNU General Public License as published by
+# the Free Software Foundation, either version 3 of the License, or
+# (at your option) any later version.
+#
+# diffoscope is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with diffoscope.  If not, see <https://www.gnu.org/licenses/>.
+
+import pytest
+
+from diffoscope.comparators.zip import ZipFile
+from diffoscope.comparators.gzip import GzipFile
+
+from comparators.utils.data import load_fixture, get_data
+
+quine1 = load_fixture('quine.gz')
+quine2 = load_fixture('quine.zip')
+
+
+def test_identification(quine1, quine2):
+    assert isinstance(quine1, GzipFile)
+    assert isinstance(quine2, ZipFile)
+
+
+def test_no_differences(quine1):
+    difference = quine1.compare(quine1)
+    assert difference is None
+
+
+ at pytest.fixture
+def differences(quine1, quine2):
+    return quine1.compare(quine2).details
+
+
+def test_difference(differences):
+    # Check that we are not recursively unpacking the quines in an infinite
+    # loop. See <https://research.swtch.com/zip>
+
+    expected_diff = get_data('quine_expected_diff')
+    assert differences[0].unified_diff == expected_diff

-- 
Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/reproducible/diffoscope.git