[diffoscope] 01/02: Simplify call to subprocess.Popen

Ximin Luo infinity0 at debian.org
Thu Feb 9 22:16:33 CET 2017


This is an automated email from the git hooks/post-receive script.

infinity0 pushed a commit to branch master
in repository diffoscope.

commit 64f6ff1a26fdd33004fb2cb2203735693b8c974c
Author: Ximin Luo <infinity0 at debian.org>
Date:   Thu Feb 9 21:30:06 2017 +0100

    Simplify call to subprocess.Popen
---
 diffoscope/diff.py | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/diffoscope/diff.py b/diffoscope/diff.py
index 5ec2ade..2b6a277 100644
--- a/diffoscope/diff.py
+++ b/diffoscope/diff.py
@@ -163,14 +163,10 @@ def run_diff(fifo1, fifo2, end_nl_q1, end_nl_q2):
 
     p = subprocess.Popen(
         cmd,
-        shell=False,
         bufsize=1,
-        stdin=subprocess.PIPE,
         stdout=subprocess.PIPE,
         stderr=subprocess.STDOUT,
     )
-    p.stdin.close()
-
     parser = DiffParser(p.stdout, end_nl_q1, end_nl_q2)
     parser.parse()
     p.wait()

-- 
Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/reproducible/diffoscope.git


More information about the diffoscope mailing list