[diffoscope] 01/01: Remove pointless use of a thread

Ximin Luo infinity0 at debian.org
Thu Feb 9 21:03:51 CET 2017

This is an automated email from the git hooks/post-receive script.

infinity0 pushed a commit to branch master
in repository diffoscope.

commit 6ec3e00b7f1ab3835b320bf9b46bf703b3e1011c
Author: Ximin Luo <infinity0 at debian.org>
Date:   Thu Feb 9 21:03:33 2017 +0100

    Remove pointless use of a thread
    This is a leftover from continued refactorings starting all the way back in
    debbindiff, when this part actually did run two threads - see `git log -p --
    debbindiff/difference.py` for details.
    However the curent form (start-join) is just pointless so get rid of it.
 diffoscope/diff.py | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/diffoscope/diff.py b/diffoscope/diff.py
index de2c416..5ec2ade 100644
--- a/diffoscope/diff.py
+++ b/diffoscope/diff.py
@@ -172,10 +172,7 @@ def run_diff(fifo1, fifo2, end_nl_q1, end_nl_q2):
     parser = DiffParser(p.stdout, end_nl_q1, end_nl_q2)
-    t_read = threading.Thread(target=parser.parse)
-    t_read.daemon = True
-    t_read.start()
-    t_read.join()
+    parser.parse()

Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/reproducible/diffoscope.git

More information about the diffoscope mailing list