[diffoscope] [Reproducible-builds] Bug#826711: diffoscope: please add argument completion

[Paul Wise]

On Sat, 2016-06-11 at 16:31 +0530, Satyam Zode wrote:

> Please find an attached patch which enables argument completion for
> diffoscope. Looking forward to review and feedback.

Thanks for the patch.

> +++ b/debian/control
> @@ -20,6 +20,7 @@ Build-Depends:
> + python3-argcomplete,

I think you need it in Depends/Recommends too?
Probably put it in the dh_python3 args.

> +    if argcomplete:
> +        argcomplete.autocomplete(parser)

I think it should exit with an error when completion is enabled
(_ARGCOMPLETE env var) but the argcomplete module is not installed.

-- 
bye,
pabs

https://wiki.debian.org/PaulWise
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 801 bytes
Desc: This is a digitally signed message part
URL: <http://lists.reproducible-builds.org/pipermail/diffoscope/attachments/20160611/fb8e28ac/attachment.sig>