[diffoscope] 04/06: comparators.utils.command: Tidy command execution log messages.

Chris Lamb chris at chris-lamb.co.uk
Wed Dec 28 19:40:01 CET 2016


This is an automated email from the git hooks/post-receive script.

lamby pushed a commit to branch master
in repository diffoscope.

commit 1c1c0046ec43d2b339fde09385fbdd7a5156f08c
Author: Chris Lamb <lamby at debian.org>
Date:   Wed Dec 28 17:29:35 2016 +0000

    comparators.utils.command: Tidy command execution log messages.
    
    Signed-off-by: Chris Lamb <lamby at debian.org>
---
 diffoscope/comparators/utils/command.py | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/diffoscope/comparators/utils/command.py b/diffoscope/comparators/utils/command.py
index 97ceeb5..d497e22 100644
--- a/diffoscope/comparators/utils/command.py
+++ b/diffoscope/comparators/utils/command.py
@@ -28,7 +28,7 @@ from diffoscope.logging import logger
 class Command(object, metaclass=abc.ABCMeta):
     def __init__(self, path):
         self._path = path
-        logger.debug('running %s', self.cmdline())
+        logger.debug("Executing %s", ' '.join(self.cmdline()))
         self._process = subprocess.Popen(self.cmdline(),
                                          shell=False, close_fds=True,
                                          env=self.env(),
@@ -83,7 +83,11 @@ class Command(object, metaclass=abc.ABCMeta):
             self._stdin_feeder.join()
         self._stderr_reader.join()
         returncode = self._process.wait()
-        logger.debug('done with %s. exit code %d', self.cmdline()[0], returncode)
+        logger.debug(
+            "%s returned (exit code: %d)",
+            ' '.join(self.cmdline()),
+            returncode,
+        )
         return returncode
 
     MAX_STDERR_LINES = 50

-- 
Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/reproducible/diffoscope.git


More information about the diffoscope mailing list