[diffoscope] 01/01: Use js-beautify as JavaScript code beautifier for .js files

Emanuel Bronshtein e3amn2l at gmx.com
Wed Dec 21 03:32:21 CET 2016


Sure, here is the test:
https://anonscm.debian.org/git/reproducible/diffoscope.git/commit/?id=9bbcf2f6ce5dc711a9dc07c731cddcc5db9fa681
js-beautify can be installed also with `pip install jsbeautifier` (from upstream https://github.com/beautify-web/js-beautify).
is there a way to add pip packages in diffoscope as alternative way to install tools? (in case there is no packaged version in distro)

Thanks,
-Emanuel.

Sent: Monday, December 19, 2016 at 4:32 PM
From: "Mattia Rizzolo" <mattia at debian.org>
To: reproducible-builds at lists.alioth.debian.org, "Emanuel Bronshtein" <e3amn2l at gmx.com>
Cc: diffoscope at lists.reproducible-builds.org
Subject: Re: [diffoscope] 01/01: Use js-beautify as JavaScript code beautifier for .js files
Hey Emanuel :)

On Sun, Dec 18, 2016 at 09:55:08PM +0000, Emanuel Bronshtein wrote:
> e3amn2l-guest pushed a commit to branch master
> in repository diffoscope.
>
> commit 002f05444cc0a238d8e617b31dabef4111b4ecd2
> Author: Emanuel Bronshtein <e3amn2l at gmx.com>
> Date: Sun Dec 18 23:52:51 2016 +0200
>
> Use js-beautify as JavaScript code beautifier for .js files
>
> JavaScript code can be minified (See #838984) or not well formatted.
> ---
> debian/control | 1 +
> diffoscope/comparators/__init__.py | 1 +
> diffoscope/comparators/javascript.py | 42 ++++++++++++++++++++++++++++++++++++
> diffoscope/exc.py | 3 +++
> 4 files changed, 47 insertions(+)


nice contribution (which also triggered #848609 from me), but a thing is
missing: tests!
We really love tests, so could you please come up with some for this
comparator too? :)

--
regards,
Mattia Rizzolo

GPG Key: 66AE 2B4A FCCF 3F52 DA18 4D18 4B04 3FCD B944 4540 .''`.
more about me: https://mapreri.org : :' :
Launchpad user: https://launchpad.net/~mapreri[https://launchpad.net/~mapreri] `. `'`
Debian QA page: https://qa.debian.org/developer.php?login=mattia[https://qa.debian.org/developer.php?login=mattia] `-


More information about the diffoscope mailing list