[diffoscope] 02/02: Sort the file list in directory comparator

Jérémy Bobbio lunar at moszumanska.debian.org
Fri Dec 18 11:45:27 CET 2015


This is an automated email from the git hooks/post-receive script.

lunar pushed a commit to branch master
in repository diffoscope.

commit f12ad6df800d6728d43b09086c2cb07137c8245d
Author: Jérémy Bobbio <lunar at debian.org>
Date:   Fri Dec 18 11:41:09 2015 +0100

    Sort the file list in directory comparator
    
    When we compare which files are in directories, we are not interested in
    comparing the order in which the filesystem returns them as we have
    no power over it.
    
    Thanks Mike Hommey for reporting the issue.
    
    Closes: #808003
---
 diffoscope/comparators/directory.py | 1 +
 1 file changed, 1 insertion(+)

diff --git a/diffoscope/comparators/directory.py b/diffoscope/comparators/directory.py
index 381a2ae..a27745e 100644
--- a/diffoscope/comparators/directory.py
+++ b/diffoscope/comparators/directory.py
@@ -35,6 +35,7 @@ def list_files(path):
     for root, dirs, names in os.walk(path):
         all_files.extend([os.path.join(root[len(path) + 1:], dir) for dir in dirs])
         all_files.extend([os.path.join(root[len(path) + 1:], name) for name in names])
+    all_files.sort()
     return all_files
 
 

-- 
Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/reproducible/diffoscope.git


More information about the diffoscope mailing list