<!DOCTYPE html PUBLIC "-//W3C//DTD HTML 4.0 Transitional//EN" "http://www.w3.org/TR/REC-html40/loose.dtd">
<html lang="en">
<head>
<meta content="text/html; charset=utf-8" http-equiv="Content-Type">
<title>
GitLab
</title>
<style>img {
max-width: 100%; height: auto;
}
</style>
</head>
<body>
<div class="content">
<h3>
Chris Lamb pushed to branch master
at <a href="https://salsa.debian.org/reproducible-builds/disorderfs">Reproducible Builds / disorderfs</a>
</h3>
<h4>
Commits:
</h4>
<ul>
<li>
<strong><a href="https://salsa.debian.org/reproducible-builds/disorderfs/commit/bd35aeb6e9dd53fb00e1cfd0923ac191fa1e082d">bd35aeb6</a></strong>
<div>
<span>by Chris Lamb</span>
<i>at 2019-01-27T21:48:54Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Ignore the return values to fsyncdir to ensure (for example) dpkg(1) can "flush" /var/lib/dpkg.
</pre>
</li>
</ul>
<h4>1 changed file:</h4>
<ul>
<li class="file-stats">
<a href="#e83a41ff8cd4fb20749ae64a556e9c18bb5d81a8">
disorderfs.cpp
</a>
</li>
</ul>
<h4>Changes:</h4>
<li id="e83a41ff8cd4fb20749ae64a556e9c18bb5d81a8">
<a href="https://salsa.debian.org/reproducible-builds/disorderfs/commit/bd35aeb6e9dd53fb00e1cfd0923ac191fa1e082d#e83a41ff8cd4fb20749ae64a556e9c18bb5d81a8"><strong>disorderfs.cpp</strong></a>
<hr>
<table class="code white" style="font-family: monospace; font-size: 90%;" bgcolor="#fff" width="100%" cellpadding="0" cellspacing="0">
<tr class="line_holder match" id="" style="line-height: 1.6;">
<td class="diff-line-num unfold js-unfold old_line" data-linenumber="477" style="width: 35px; color: rgba(0,0,0,0.3); border-right-width: 1px; border-right-color: #f0f0f0; border-right-style: solid; padding: 0 5px;" align="right" bgcolor="#fafafa">...</td>
<td class="diff-line-num unfold js-unfold new_line" data-linenumber="477" style="width: 35px; color: rgba(0,0,0,0.3); border-right-width: 1px; border-right-color: #f0f0f0; border-right-style: solid; padding: 0 5px;" align="right" bgcolor="#fafafa">...</td>
<td class="line_content match " style="padding-left: 0.5em; padding-right: 0.5em; color: rgba(0,0,0,0.3);" bgcolor="#fafafa">@@ -477,7 +477,8 @@ int main (int argc, char** argv)</td>
</tr>
<tr class="line_holder" id="" style="line-height: 1.6;">
<td class="diff-line-num old_line" data-linenumber="477" style="width: 35px; color: rgba(0,0,0,0.3); border-right-width: 1px; border-right-color: #f0f0f0; border-right-style: solid; padding: 0 5px;" align="right" bgcolor="#fafafa">
477
</td>
<td class="diff-line-num new_line" data-linenumber="477" style="width: 35px; color: rgba(0,0,0,0.3); border-right-width: 1px; border-right-color: #f0f0f0; border-right-style: solid; padding: 0 5px;" align="right" bgcolor="#fafafa">
477
</td>
<td class="line_content noteable_line" style="padding-left: 0.5em; padding-right: 0.5em;">
<pre style="margin: 0;"> <span id="LC477" class="line" lang="cpp"> <span class="p">};</span></span>
</pre>
</td>
</tr>
<tr class="line_holder" id="" style="line-height: 1.6;">
<td class="diff-line-num old_line" data-linenumber="478" style="width: 35px; color: rgba(0,0,0,0.3); border-right-width: 1px; border-right-color: #f0f0f0; border-right-style: solid; padding: 0 5px;" align="right" bgcolor="#fafafa">
478
</td>
<td class="diff-line-num new_line" data-linenumber="478" style="width: 35px; color: rgba(0,0,0,0.3); border-right-width: 1px; border-right-color: #f0f0f0; border-right-style: solid; padding: 0 5px;" align="right" bgcolor="#fafafa">
478
</td>
<td class="line_content noteable_line" style="padding-left: 0.5em; padding-right: 0.5em;">
<pre style="margin: 0;"> <span id="LC478" class="line" lang="cpp"> <span class="n" style="color: #333;">disorderfs_fuse_operations</span><span class="p">.</span><span class="n" style="color: #333;">fsyncdir</span> <span class="o" style="font-weight: 600;">=</span> <span class="p">[]</span> <span class="p">(</span><span class="k" style="font-weight: 600;">const</span> <span class="kt" style="color: #458; font-weight: 600;">char</span><span class="o" style="font-weight: 600;">*</span> <span class="n" style="color: #333;">path</span><span class="p">,</span> <span class="kt" style="color: #458; font-weight: 600;">int</span> <span class="n" style="color: #333;">is_datasync</span><span class="p">,</span> <span class="k" style="font-weight: 600;">struct</span> <span class="n" style="color: #333;">fuse_file_info</span><span class="o" style="font-weight: 600;">*</span> <span class="n" style="color: #333;">info</span><span class="p">)</span> <span class="o" style="font-weight: 600;">-></span> <span class="kt" style="color: #458; font-weight: 600;">int</span> <span class="p">{</span></span>
</pre>
</td>
</tr>
<tr class="line_holder" id="" style="line-height: 1.6;">
<td class="diff-line-num old_line" data-linenumber="479" style="width: 35px; color: rgba(0,0,0,0.3); border-right-width: 1px; border-right-color: #f0f0f0; border-right-style: solid; padding: 0 5px;" align="right" bgcolor="#fafafa">
479
</td>
<td class="diff-line-num new_line" data-linenumber="479" style="width: 35px; color: rgba(0,0,0,0.3); border-right-width: 1px; border-right-color: #f0f0f0; border-right-style: solid; padding: 0 5px;" align="right" bgcolor="#fafafa">
479
</td>
<td class="line_content noteable_line" style="padding-left: 0.5em; padding-right: 0.5em;">
<pre style="margin: 0;"> <span id="LC479" class="line" lang="cpp"> <span class="c1" style="color: #998; font-style: italic;">// XXX: is it OK to just use fsync? Not clear on why FUSE has a separate fsyncdir operation</span></span>
</pre>
</td>
</tr>
<tr class="line_holder old" id="" style="line-height: 1.6;">
<td class="diff-line-num old old_line" data-linenumber="480" style="width: 35px; color: rgba(0,0,0,0.3); border-right-width: 1px; border-right-color: #fac5cd; border-right-style: solid; padding: 0 5px;" align="right" bgcolor="#f9d7dc">
480
</td>
<td class="diff-line-num new_line old" data-linenumber="480" style="width: 35px; color: rgba(0,0,0,0.3); border-right-width: 1px; border-right-color: #fac5cd; border-right-style: solid; padding: 0 5px;" align="right" bgcolor="#f9d7dc">
</td>
<td class="line_content noteable_line old" style="padding-left: 0.5em; padding-right: 0.5em;" bgcolor="#fbe9eb">
<pre style="margin: 0;">-<span id="LC480" class="line" lang="cpp"> <span class="k" style="font-weight: 600;">return</span> <span class="n" style="color: #333;">wrap</span><span class="p">(</span><span class="n" style="color: #333;">is_datasync</span> <span class="o" style="font-weight: 600;">?</span> <span class="n" style="color: #333;">fdatasync</span><span class="p">(</span><span class="n" style="color: #333;">info</span><span class="o" style="font-weight: 600;">-></span><span class="n" style="color: #333;">fh</span><span class="p">)</span> <span class="o" style="font-weight: 600;">:</span> <span class="n" style="color: #333;">fsync</span><span class="p">(</span><span class="n" style="color: #333;">info</span><span class="o" style="font-weight: 600;">-></span><span class="n" style="color: #333;">fh</span><span class="p">));</span></span>
</pre>
</td>
</tr>
<tr class="line_holder new" id="" style="line-height: 1.6;">
<td class="diff-line-num new old_line" data-linenumber="481" style="width: 35px; color: rgba(0,0,0,0.3); border-right-width: 1px; border-right-color: #c7f0d2; border-right-style: solid; padding: 0 5px;" align="right" bgcolor="#ddfbe6">
</td>
<td class="diff-line-num new new_line" data-linenumber="480" style="width: 35px; color: rgba(0,0,0,0.3); border-right-width: 1px; border-right-color: #c7f0d2; border-right-style: solid; padding: 0 5px;" align="right" bgcolor="#ddfbe6">
480
</td>
<td class="line_content new noteable_line" style="padding-left: 0.5em; padding-right: 0.5em;" bgcolor="#ecfdf0">
<pre style="margin: 0;">+<span id="LC480" class="line" lang="cpp"> <span class="n" style="color: #333;">wrap</span><span class="p">(</span><span class="n" style="color: #333;">is_datasync</span> <span class="o" style="font-weight: 600;">?</span> <span class="n" style="color: #333;">fdatasync</span><span class="p">(</span><span class="n" style="color: #333;">info</span><span class="o" style="font-weight: 600;">-></span><span class="n" style="color: #333;">fh</span><span class="p">)</span> <span class="o" style="font-weight: 600;">:</span> <span class="n" style="color: #333;">fsync</span><span class="p">(</span><span class="n" style="color: #333;">info</span><span class="o" style="font-weight: 600;">-></span><span class="n" style="color: #333;">fh</span><span class="p">));</span></span>
</pre>
</td>
</tr>
<tr class="line_holder new" id="" style="line-height: 1.6;">
<td class="diff-line-num new old_line" data-linenumber="481" style="width: 35px; color: rgba(0,0,0,0.3); border-right-width: 1px; border-right-color: #c7f0d2; border-right-style: solid; padding: 0 5px;" align="right" bgcolor="#ddfbe6">
</td>
<td class="diff-line-num new new_line" data-linenumber="481" style="width: 35px; color: rgba(0,0,0,0.3); border-right-width: 1px; border-right-color: #c7f0d2; border-right-style: solid; padding: 0 5px;" align="right" bgcolor="#ddfbe6">
481
</td>
<td class="line_content new noteable_line" style="padding-left: 0.5em; padding-right: 0.5em;" bgcolor="#ecfdf0">
<pre style="margin: 0;">+<span id="LC481" class="line" lang="cpp"> <span class="k" style="font-weight: 600;">return</span> <span class="mi" style="color: #099;">0</span><span class="p">;</span> <span class="c1" style="color: #998; font-style: italic;">// return value is ignored</span></span>
</pre>
</td>
</tr>
<tr class="line_holder" id="" style="line-height: 1.6;">
<td class="diff-line-num old_line" data-linenumber="481" style="width: 35px; color: rgba(0,0,0,0.3); border-right-width: 1px; border-right-color: #f0f0f0; border-right-style: solid; padding: 0 5px;" align="right" bgcolor="#fafafa">
481
</td>
<td class="diff-line-num new_line" data-linenumber="482" style="width: 35px; color: rgba(0,0,0,0.3); border-right-width: 1px; border-right-color: #f0f0f0; border-right-style: solid; padding: 0 5px;" align="right" bgcolor="#fafafa">
482
</td>
<td class="line_content noteable_line" style="padding-left: 0.5em; padding-right: 0.5em;">
<pre style="margin: 0;"> <span id="LC482" class="line" lang="cpp"> <span class="p">};</span></span>
</pre>
</td>
</tr>
<tr class="line_holder" id="" style="line-height: 1.6;">
<td class="diff-line-num old_line" data-linenumber="482" style="width: 35px; color: rgba(0,0,0,0.3); border-right-width: 1px; border-right-color: #f0f0f0; border-right-style: solid; padding: 0 5px;" align="right" bgcolor="#fafafa">
482
</td>
<td class="diff-line-num new_line" data-linenumber="483" style="width: 35px; color: rgba(0,0,0,0.3); border-right-width: 1px; border-right-color: #f0f0f0; border-right-style: solid; padding: 0 5px;" align="right" bgcolor="#fafafa">
483
</td>
<td class="line_content noteable_line" style="padding-left: 0.5em; padding-right: 0.5em;">
<pre style="margin: 0;"> <span id="LC483" class="line" lang="cpp"> <span class="n" style="color: #333;">disorderfs_fuse_operations</span><span class="p">.</span><span class="n" style="color: #333;">create</span> <span class="o" style="font-weight: 600;">=</span> <span class="p">[]</span> <span class="p">(</span><span class="k" style="font-weight: 600;">const</span> <span class="kt" style="color: #458; font-weight: 600;">char</span><span class="o" style="font-weight: 600;">*</span> <span class="n" style="color: #333;">path</span><span class="p">,</span> <span class="n" style="color: #333;">mode_t</span> <span class="n" style="color: #333;">mode</span><span class="p">,</span> <span class="k" style="font-weight: 600;">struct</span> <span class="n" style="color: #333;">fuse_file_info</span><span class="o" style="font-weight: 600;">*</span> <span class="n" style="color: #333;">info</span><span class="p">)</span> <span class="o" style="font-weight: 600;">-></span> <span class="kt" style="color: #458; font-weight: 600;">int</span> <span class="p">{</span></span>
</pre>
</td>
</tr>
<tr class="line_holder" id="" style="line-height: 1.6;">
<td class="diff-line-num old_line" data-linenumber="483" style="width: 35px; color: rgba(0,0,0,0.3); border-right-width: 1px; border-right-color: #f0f0f0; border-right-style: solid; padding: 0 5px;" align="right" bgcolor="#fafafa">
483
</td>
<td class="diff-line-num new_line" data-linenumber="484" style="width: 35px; color: rgba(0,0,0,0.3); border-right-width: 1px; border-right-color: #f0f0f0; border-right-style: solid; padding: 0 5px;" align="right" bgcolor="#fafafa">
484
</td>
<td class="line_content noteable_line" style="padding-left: 0.5em; padding-right: 0.5em;">
<pre style="margin: 0;"> <span id="LC484" class="line" lang="cpp"> <span class="n" style="color: #333;">Guard</span> <span class="n" style="color: #333;">g</span><span class="p">;</span></span>
</pre>
</td>
</tr>
</table>
<br>
</li>
</div>
<div class="footer" style="margin-top: 10px;">
<p style="font-size: small; color: #777777;">
—
<br>
<a href="https://salsa.debian.org/reproducible-builds/disorderfs/commit/bd35aeb6e9dd53fb00e1cfd0923ac191fa1e082d">View it on GitLab</a>.
<br>
You're receiving this email because of your account on salsa.debian.org.
If you'd like to receive fewer emails, you can
adjust your notification settings.
<script type="application/ld+json">{"@context":"http://schema.org","@type":"EmailMessage","action":{"@type":"ViewAction","name":"View Commit","url":"https://salsa.debian.org/reproducible-builds/disorderfs/commit/bd35aeb6e9dd53fb00e1cfd0923ac191fa1e082d"}}</script>
</p>
</div>
</body>
</html>