<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
<meta name="Generator" content="Microsoft Exchange Server">
<!-- converted from text --><style><!-- .EmailQuote { margin-left: 1pt; padding-left: 4pt; border-left: #800000 2px solid; } --></style>
</head>
<body>
<meta content="text/html; charset=UTF-8">
<style type="text/css" style="">
<!--
p
{margin-top:0;
margin-bottom:0}
-->
</style>
<div dir="ltr">
<div id="x_divtagdefaultwrapper" dir="ltr" style="font-size:12pt; color:#000000; font-family:Garamond,Georgia,serif">
<p>Hi Chris,</p>
<p><br>
</p>
<p>Thanks for the quick fix!</p>
<p><br>
</p>
<p>I tried the latest build on master and it works well. I also noticed that you have removed ANSI sequences completely and don't choose to keep it when `--text-color` is `always` . This behaviour is also fine with me plus I guess it is easier to maintain as
`--text-color` would mean the colour for the diff output. Thank you so much! <br>
</p>
<p><br>
</p>
<div id="x_Signature">
<div id="x_divtagdefaultwrapper" dir="ltr" style="font-size:12pt; color:rgb(0,0,0); font-family:Calibri,Helvetica,sans-serif,"EmojiFont","Apple Color Emoji","Segoe UI Emoji",NotoColorEmoji,"Segoe UI Symbol","Android Emoji",EmojiSymbols">
<div id="x_m_4935352394101912768Signature">
<div name="x_divtagdefaultwrapper"><font size="2" color="#808080"><span style="font-family:Arial,"Helvetica Neue",helvetica,sans-serif; background-color:rgb(255,255,255)"><span id="x_divtagdefaultwrapper" style="font-size:12pt">
<div style="margin-top:0; margin-bottom:0"><span style="color:rgb(0,0,0); font-family:Garamond,Georgia,serif">Regards,</span></div>
<span style="font-family:Garamond,Georgia,serif"></span><span style="font-family:Garamond,Georgia,serif"></span><span style="color:rgb(0,0,0)"></span><span style="font-family:Garamond,Georgia,serif"></span><span style="font-family:Garamond,Georgia,serif"></span>
<div style="margin-top:0; margin-bottom:0"><span style="color:rgb(0,0,0); font-family:Garamond,Georgia,serif">Aman Sharma</span></div>
</span><br>
</span></font></div>
<div name="x_divtagdefaultwrapper"><font size="2" color="#808080"><span style="font-family:Arial,"Helvetica Neue",helvetica,sans-serif; background-color:rgb(255,255,255)"></span><span class="x_im">PhD Student<br style="font-family:Arial,"Helvetica Neue",helvetica,sans-serif">
<span style="font-family:Arial,"Helvetica Neue",helvetica,sans-serif; background-color:rgb(255,255,255)">KTH Royal Institute of Technology</span><br style="font-family:Arial,"Helvetica Neue",helvetica,sans-serif">
</span><span style="font-family:Arial,"Helvetica Neue",helvetica,sans-serif; background-color:rgb(255,255,255)">School of Electrical Engineering and Computer Science (EECS)</span><br style="font-family:Arial,"Helvetica Neue",helvetica,sans-serif">
<span style="font-family:Arial,"Helvetica Neue",helvetica,sans-serif; background-color:rgb(255,255,255)">Department of Theoretical Computer Science (TCS)</span><br style="font-family:Arial,"Helvetica Neue",helvetica,sans-serif">
<span style="font-family:Arial,"Helvetica Neue",helvetica,sans-serif; background-color:rgb(255,255,255)"><a href="http://www.kth.se" target="_blank" id="LPNoLP"></a><a href="https://www.kth.se/profile/amansha" class="x_OWAAutoLink" id="LPNoLP"></a><a href="https://www.kth.se/profile/amansha" class="x_OWAAutoLink" id="LPNoLP"></a></span></font></div>
</div>
<a href="https://www.kth.se/profile/amansha" class="x_OWAAutoLink" id="LPNoLP"><span style="font-size:10pt"></span></a><a href="https://algomaster99.github.io/" class="x_OWAAutoLink" id="LPNoLP">https://algomaster99.github.io/</a><br>
</div>
</div>
</div>
<hr tabindex="-1" style="display:inline-block; width:98%">
<div id="x_divRplyFwdMsg" dir="ltr"><font face="Calibri, sans-serif" color="#000000" style="font-size:11pt"><b>From:</b> Chris Lamb <chris@reproducible-builds.org><br>
<b>Sent:</b> Friday, August 16, 2024 12:27:54 PM<br>
<b>To:</b> Aman Sharma<br>
<b>Cc:</b> diffoscope<br>
<b>Subject:</b> Re: [diffoscope] Procyon decompiler outputs with ANSI color codes so --text-color has no effect on it</font>
<div> </div>
</div>
</div>
<font size="2"><span style="font-size:10pt;">
<div class="PlainText">Hi Aman,<br>
<br>
Thanks for the report.<br>
<br>
> 3. We use regex to remove all ANSI codes while processing the diff in<br>
> diffoscope.<br>
<br>
I think this is the best solution as we already have a code to strip<br>
ANSI codes elsewhere in the codebase and we can quickly turn that into<br>
a library module.<br>
<br>
Indeed, can you try applying these commits that I've just pushed to<br>
master?<br>
<br>
* <a href="https://salsa.debian.org/reproducible-builds/diffoscope/commit/d16faf7c78ba84f759c417a9412c92f6dd08adca.diff">
https://salsa.debian.org/reproducible-builds/diffoscope/commit/d16faf7c78ba84f759c417a9412c92f6dd08adca.diff</a><br>
* <a href="https://salsa.debian.org/reproducible-builds/diffoscope/commit/12e34398cf72c46eb0eb1d3883a9b215f1aec06b.diff">
https://salsa.debian.org/reproducible-builds/diffoscope/commit/12e34398cf72c46eb0eb1d3883a9b215f1aec06b.diff</a><br>
<br>
<br>
Best wishes,<br>
<br>
-- <br>
o<br>
⬋ ⬊ Chris Lamb<br>
o o reproducible-builds.org 💠<br>
⬊ ⬋<br>
o<br>
</div>
</span></font>
</body>
</html>