<html><head></head><body><div style="font-family: Verdana;font-size: 12.0px;"><div>No, it's a partial fix, see my replay in #836786
<div>
<div>https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=836786#10</div>
<div> </div>
<div>-Emanuel</div>
<div style="margin: 10.0px 5.0px 5.0px 10.0px;padding: 10.0px 0 10.0px 10.0px;border-left: 2.0px solid rgb(195,217,229);">
<div style="margin: 0 0 10.0px 0;"><b>Sent:</b> Monday, December 26, 2016 at 8:20 PM<br/>
<b>From:</b> "Ximin Luo" <infinity0@debian.org><br/>
<b>To:</b> "Emanuel Bronshtein" <e3amn2l@gmx.com>, "Mattia Rizzolo" <mattia@debian.org><br/>
<b>Cc:</b> diffoscope@lists.reproducible-builds.org, reproducible-builds@lists.alioth.debian.org<br/>
<b>Subject:</b> Re: [diffoscope] 01/01: Use js-beautify as JavaScript code beautifier for .js files</div>
<div>Hey, thanks for this!<br/>
<br/>
A question - do you consider #836786 closed by this patch, or is there still more work to be done on it?<br/>
<br/>
(#836786 - diffoscope: Differences between long lines are missing in HTML format")<br/>
<br/>
X<br/>
<br/>
Emanuel Bronshtein:<br/>
> Sure, here is the test:<br/>
> <a href="https://anonscm.debian.org/git/reproducible/diffoscope.git/commit/?id=9bbcf2f6ce5dc711a9dc07c731cddcc5db9fa681" target="_blank">https://anonscm.debian.org/git/reproducible/diffoscope.git/commit/?id=9bbcf2f6ce5dc711a9dc07c731cddcc5db9fa681</a><br/>
> js-beautify can be installed also with `pip install jsbeautifier` (from upstream <a href="https://github.com/beautify-web/js-beautify" target="_blank">https://github.com/beautify-web/js-beautify</a>).<br/>
> is there a way to add pip packages in diffoscope as alternative way to install tools? (in case there is no packaged version in distro)<br/>
><br/>
> Thanks,<br/>
> -Emanuel.<br/>
><br/>
> Sent: Monday, December 19, 2016 at 4:32 PM<br/>
> From: "Mattia Rizzolo" <mattia@debian.org><br/>
> To: reproducible-builds@lists.alioth.debian.org, "Emanuel Bronshtein" <e3amn2l@gmx.com><br/>
> Cc: diffoscope@lists.reproducible-builds.org<br/>
> Subject: Re: [diffoscope] 01/01: Use js-beautify as JavaScript code beautifier for .js files<br/>
> Hey Emanuel :)<br/>
><br/>
> On Sun, Dec 18, 2016 at 09:55:08PM +0000, Emanuel Bronshtein wrote:<br/>
>> e3amn2l-guest pushed a commit to branch master<br/>
>> in repository diffoscope.<br/>
>><br/>
>> commit 002f05444cc0a238d8e617b31dabef4111b4ecd2<br/>
>> Author: Emanuel Bronshtein <e3amn2l@gmx.com><br/>
>> Date: Sun Dec 18 23:52:51 2016 +0200<br/>
>><br/>
>> Use js-beautify as JavaScript code beautifier for .js files<br/>
>><br/>
>> JavaScript code can be minified (See #838984) or not well formatted.<br/>
>> ---<br/>
>> debian/control | 1 +<br/>
>> diffoscope/comparators/__init__.py | 1 +<br/>
>> diffoscope/comparators/javascript.py | 42 ++++++++++++++++++++++++++++++++++++<br/>
>> diffoscope/exc.py | 3 +++<br/>
>> 4 files changed, 47 insertions(+)<br/>
><br/>
><br/>
> nice contribution (which also triggered #848609 from me), but a thing is<br/>
> missing: tests!<br/>
> We really love tests, so could you please come up with some for this<br/>
> comparator too? :)<br/>
><br/>
> --<br/>
> regards,<br/>
> Mattia Rizzolo<br/>
><br/>
> GPG Key: 66AE 2B4A FCCF 3F52 DA18 4D18 4B04 3FCD B944 4540 .''`.<br/>
> more about me: <a href="https://mapreri.org" target="_blank">https://mapreri.org</a> : :' :<br/>
> Launchpad user: <a href="https://launchpad.net/~mapreri" target="_blank">https://launchpad.net/~mapreri</a>[<a href="https://launchpad.net/~mapreri" target="_blank">https://launchpad.net/~mapreri</a>] `. `'`<br/>
> Debian QA page: <a href="https://qa.debian.org/developer.php?login=mattia" target="_blank">https://qa.debian.org/developer.php?login=mattia</a>[<a href="https://qa.debian.org/developer.php?login=mattia" target="_blank">https://qa.debian.org/developer.php?login=mattia</a>] `-<br/>
><br/>
> _______________________________________________<br/>
> Reproducible-builds mailing list<br/>
> Reproducible-builds@lists.alioth.debian.org<br/>
> <a href="http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/reproducible-builds" target="_blank">http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/reproducible-builds</a><br/>
><br/>
<br/>
<br/>
--<br/>
GPG: ed25519/56034877E1F87C35<br/>
GPG: rsa4096/1318EFAC5FBBDBCE<br/>
<a href="https://github.com/infinity0/pubkeys.git" target="_blank">https://github.com/infinity0/pubkeys.git</a></div>
</div>
</div>
</div></div></body></html>