[diffoscope] 01/01: Sort output of xattr.get_all - according to listxattr(2) they are unsorted.

Chris Lamb chris at chris-lamb.co.uk
Thu Jan 25 09:35:56 CET 2018


This is an automated email from the git hooks/post-receive script.

lamby pushed a commit to branch master
in repository diffoscope.

commit 5fcd71891aad9b7ed5195f490e7e42c3a12fa3d0
Author: Chris Lamb <lamby at debian.org>
Date:   Thu Jan 25 19:35:21 2018 +1100

    Sort output of xattr.get_all - according to listxattr(2) they are unsorted.
---
 diffoscope/comparators/directory.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/diffoscope/comparators/directory.py b/diffoscope/comparators/directory.py
index df5211a..19a0d97 100644
--- a/diffoscope/comparators/directory.py
+++ b/diffoscope/comparators/directory.py
@@ -118,7 +118,7 @@ def xattr(path1, path2):
         return '\n'.join('{}: {}'.format(
             k.decode('utf-8', 'ignore'),
             v.decode('utf-8', 'ignore'),
-        ) for k, v in xattr.get_all(x))
+        ) for k, v in sorted(xattr.get_all(x)))
 
     return Difference.from_text(
         fn(path1), fn(path2), path1, path2, source='extended file attributes',

-- 
Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/reproducible/diffoscope.git


More information about the diffoscope mailing list