[diffoscope] 01/01: comparators/zip: exec zipinfo, don't need the shell to hang around

Ximin Luo infinity0 at debian.org
Tue Nov 28 19:56:53 CET 2017


This is an automated email from the git hooks/post-receive script.

infinity0 pushed a commit to branch master
in repository diffoscope.

commit ef450c40d47145a010165e30afb3f03debf44ab9
Author: Ximin Luo <infinity0 at debian.org>
Date:   Tue Nov 28 19:54:45 2017 +0100

    comparators/zip: exec zipinfo, don't need the shell to hang around
---
 diffoscope/comparators/zip.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/diffoscope/comparators/zip.py b/diffoscope/comparators/zip.py
index 0ab60f5..950abc6 100644
--- a/diffoscope/comparators/zip.py
+++ b/diffoscope/comparators/zip.py
@@ -38,7 +38,7 @@ class Zipinfo(Command):
         # zipinfo (without -v) puts warning messages (some of which contain
         # $path) into stdin when stderr is not a tty, see #879011 for details.
         # to work around it, we run it on /dev/stdin instead, seems to work ok.
-        return ['sh', '-ec', 'zipinfo /dev/stdin < "$1"', '-', self.path]
+        return ['sh', '-ec', 'exec zipinfo /dev/stdin < "$1"', '-', self.path]
 
     def filter(self, line):
         # we don't care about the archive file path

-- 
Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/reproducible/diffoscope.git


More information about the diffoscope mailing list