[diffoscope] 02/02: tests/android: skip tests involving abootimg on BE archs (see Debian's #725729)

Mattia Rizzolo mattia at debian.org
Fri Dec 29 09:59:29 CET 2017


This is an automated email from the git hooks/post-receive script.

mattia pushed a commit to branch master
in repository diffoscope.

commit 1fdbfd9568abaab308d6fc0fafaddaff46d45c77
Author: Mattia Rizzolo <mattia at debian.org>
Date:   Wed Dec 27 14:54:58 2017 +0100

    tests/android: skip tests involving abootimg on BE archs (see Debian's #725729)
    
    Signed-off-by: Mattia Rizzolo <mattia at debian.org>
---
 tests/comparators/test_android.py | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/tests/comparators/test_android.py b/tests/comparators/test_android.py
index 5676833..6a2b646 100644
--- a/tests/comparators/test_android.py
+++ b/tests/comparators/test_android.py
@@ -17,6 +17,7 @@
 # You should have received a copy of the GNU General Public License
 # along with diffoscope.  If not, see <https://www.gnu.org/licenses/>.
 
+import sys
 import pytest
 
 from diffoscope.config import Config
@@ -29,6 +30,9 @@ from ..utils.tools import skip_unless_tools_exist
 bootimg1 = load_fixture('android1.img')
 bootimg2 = load_fixture('android2.img')
 
+# abootimg misfires on big endian architectures
+# Part of the bug: https://bugs.debian.org/725729
+bearch = sys.byteorder == 'big'
 
 def test_identification(bootimg1):
     assert isinstance(bootimg1, AndroidBootImgFile)
@@ -45,6 +49,7 @@ def differences(bootimg1, bootimg2):
 
 
 @skip_unless_tools_exist('abootimg')
+ at pytest.mark.skipif(bearch, reason='abootimg is buggy on BE architectures')
 def test_diff(differences):
     # FIXME
     with open('tests/data/android_expected_diff', 'w') as f:
@@ -54,6 +59,7 @@ def test_diff(differences):
 
 
 @skip_unless_tools_exist('abootimg')
+ at pytest.mark.skipif(bearch, reason='abootimg is buggy on BE architectures')
 def test_compare_non_existing(monkeypatch, bootimg1):
     monkeypatch.setattr(Config(), 'new_file', True)
     difference = bootimg1.compare(MissingFile('/nonexisting', bootimg1))

-- 
Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/reproducible/diffoscope.git


More information about the diffoscope mailing list