[diffoscope] 01/02: Revert "xfail ppu identification test in case of mismatching ppu version"

Mattia Rizzolo mattia at debian.org
Tue Sep 6 22:43:32 CEST 2016


This is an automated email from the git hooks/post-receive script.

mattia pushed a commit to branch master
in repository diffoscope.

commit 72a14d4f4a292ec76efdfcca67b1d99edaa17638
Author: Mattia Rizzolo <mattia at debian.org>
Date:   Tue Sep 6 20:39:48 2016 +0000

    Revert "xfail ppu identification test in case of mismatching ppu version"
    
    it somehow XFAILs also when it shouldn't, so reverting for now.
    
    This reverts commit 3a5f0741d2646a1df8c81887fb6099fb08e36e54.
---
 tests/comparators/test_ppu.py | 6 ------
 1 file changed, 6 deletions(-)

diff --git a/tests/comparators/test_ppu.py b/tests/comparators/test_ppu.py
index bb176ba..a66f9a9 100644
--- a/tests/comparators/test_ppu.py
+++ b/tests/comparators/test_ppu.py
@@ -20,7 +20,6 @@
 
 import pytest
 
-from diffoscope.comparators import FilesystemFile
 from diffoscope.comparators.ppu import PpuFile
 
 from utils import skip_unless_tools_exist, data, load_fixture, \
@@ -37,11 +36,6 @@ file2 = load_fixture(data('test2.ppu'))
 
 @skip_unless_tools_exist('ppudump')
 def test_identification(file1):
-    # If the recognition had failed due to mismatching ppu version it'll be a
-    # FilesystemFile.
-    if isinstance(file1, FilesystemFile):
-        pytest.xfail(reason="mismatch between system ppu and fixture")
-
     assert isinstance(file1, PpuFile)
 
 def test_no_differences(file1):

-- 
Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/reproducible/diffoscope.git


More information about the diffoscope mailing list