[diffoscope] [PATCH] Implement ElfFile as a container of sections

[Jérémy Bobbio]

Dhole:
> I've seen all the commits you pushed today, great work!
> 
> I would like to complement this series of patches with what I think is
> the only remaining thing mentioned by Mike Hommey: split the output from
> `readelf --debug-dump`.

Thanks! I also wanted to do see that, so your fits well.

>  def _compare_elf_data(path1, path2):
> -    return [Difference.from_command(cmd, path1, path2) for cmd in READELF_COMMANDS]
> +    return [Difference.from_command(cmd, path1, path2) for \
> +            cmd in READELF_COMMANDS if cmd != ReadelfDebugDump] + \
> +            [Difference.from_command(ReadelfDebugDump, path1, path2, \
> +            command_args=[sec_grp]) for \
> +            sec_grp in ReadelfDebugDump.DEBUG_SECTION_GROUPS]

This really felt like too much special casing for my taste. So I
implemented it slightly differently.

-- 
Lunar                                .''`. 
lunar at debian.org                    : :Ⓐ  :  # apt-get install anarchism
                                    `. `'` 
                                      `-   
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.reproducible-builds.org/pipermail/diffoscope/attachments/20160131/01044ebd/attachment.sig>